cederom commented on PR #3415:
URL: https://github.com/apache/nuttx-apps/pull/3415#issuecomment-3977926186

   Thank you @dmihai03 :-)
   * Please update and sign git commit according to 
https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md:
   ```
   examples/mqttc: Fix QOS arguments parsing (char->long).
   
   Modify the switch cases in parsearg function for QOS levels definition.
   The comparison was made between a long value and a char.
   
   Signed-off-by: ...
   ```
   * It is always nice to show logs before and after the fix to show what the 
problem was and that you fixed it. For now we only see it is working but we do 
not see it was not working before :-)
   * Other than that looks good :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to