anjiahao1 commented on PR #18427: URL: https://github.com/apache/nuttx/pull/18427#issuecomment-3949734198
> Thank you @anjiahao1 :-) I saw the mailing list discussion.. your solution seems a bit different: > > * `heap = mm_memalign(heap, MM_ALIGN, sizeof(struct mm_heap_s));` is replaced with `heap = mm_malloc(heap, sizeof(struct mm_heap_s));` > > While KR proposes adding new kconfig option to disable unused code at all in the DEFAULT_SMALL builds: > > * new Kconfig option MM_DISABLE_INIT_HEAP_POINTER, defaults to > DEFAULT_SMALL > * rptun driver depends on !MM_DISABLE_INIT_HEAP_POINTER > > This does not look functionally the same.. KR proposes disabling unused code while you change heap allocation method.. and misalignment of the heap may cause problems on some real world hardware? The default alignment for `mm_malloc` is `MM_ALIGN`, so there's no need to use `mm_memalign` here. This can be solved without adding extra `Kconfig`, which only adds jump instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
