patacongo commented on issue #128:
URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-683305652


   >  In most cases, the author of those early changes will be noted as an 
author or copyright holder in the BSD license header. In fact, I think that is 
true of all _significant_ early code contributions.
   
   I can think of one very frequent case where this is not true.  In many 
cases, people clone files from one location to another.  This is particularly 
true under arch/ and boards/.  You will discover many files that I wrote, that 
have me as the copyright holder and author but GIT will claim, incorrectly, 
that the person doing the PR/patch was the author.  This will apply to several 
hundred files.  There are cases where the info in the license header is more 
accurate than in the file header.
   
   Third party code brought into the OS will have the same issue.  The true 
author of the code is in the license header, not in the GIT log.
   
   And there are places where people make mistakes in copying files without 
updating the license headers.  For example, under net/  there are a few files 
that include some small bits of logic from Adam Dunkels.  I see that those 
files with headers have been cloned numerous times and most are no longer 
correct.  Adam Dunkels is not the author of any of the files under net/ (except 
perhaps some logic under net/sixlowpan and the TCP state machine and even those 
are very highly customized).
   
   It is all very complex and we cannot expect to get it all 100% correct.  I 
think we just have to keep a high level of integrity and do our best effort to 
discover and document all authorship.
   
   I think the point is that GIT authors may not agree with the authorship in 
the license header and those will all need some clarification.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to