patacongo commented on a change in pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#discussion_r479560380
########## File path: include/nuttx/net/net.h ########## @@ -266,6 +266,7 @@ struct socket uint8_t s_domain; /* IP domain: PF_INET, PF_INET6, or PF_PACKET */ uint8_t s_type; /* Protocol type: Only SOCK_STREAM or * SOCK_DGRAM */ + uint8_t s_proto; /* Socket Protocol */ Review comment: This should be initialized for all address families, even if there is only one option for protocol. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org