wangchdo commented on code in PR #17573: URL: https://github.com/apache/nuttx/pull/17573#discussion_r2667704120
########## include/nuttx/arch.h: ########## @@ -2101,8 +2102,8 @@ int up_timer_tick_cancel(FAR clock_t *ticks); * non-reentrancy. * ****************************************************************************/ - -#if defined(CONFIG_SCHED_TICKLESS) && !defined(CONFIG_SCHED_TICKLESS_ALARM) +#if (defined(CONFIG_HRTIMER) && defined(CONFIG_TIMER_ARCH)) || \ Review Comment: I think timer arch can also support hritmer if the timer arch is updated, although I didn't implement it yet. ########## include/nuttx/arch.h: ########## @@ -2031,7 +2031,8 @@ int up_alarm_tick_cancel(FAR clock_t *ticks); * ****************************************************************************/ -#if defined(CONFIG_SCHED_TICKLESS) && defined(CONFIG_SCHED_TICKLESS_ALARM) +#if (defined(CONFIG_HRTIMER) && defined(CONFIG_ALARM_ARCH)) || \ Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
