GUIDINGLI commented on PR #17675: URL: https://github.com/apache/nuttx/pull/17675#issuecomment-3701336222
@Fix-Point Great job ! You have clearly identified the unreasonable aspects in the original design, provided corresponding test cases and detailed explanations, and also offered solutions. However, please be mindful of your choice of words in certain places—try to avoid using terms like "incorrect" to prevent misunderstandings. We should focus on discussing technical details and avoid emotional language. In addition, as @wangchdo mentioned, you need to run more performance tests, especially in AMP scenarios. @wangchdo I see that you have made many valuable comments on this PR, which are also excellent. We don’t need to deliberately distinguish which solution is better or worse; we just need to see which one can resolve issues of stability and performance. Moreover, this PR did not revert your solution, but rather built upon it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
