Fix-Point commented on code in PR #17640:
URL: https://github.com/apache/nuttx/pull/17640#discussion_r2642621120
##########
sched/wdog/wd_start.c:
##########
@@ -265,62 +258,63 @@ int wd_start_abstick(FAR struct wdog_s *wdog, clock_t
ticks,
wdentry_t wdentry, wdparm_t arg)
{
irqstate_t flags;
- bool reassess = false;
+ bool reassess = false;
+ int ret = -EINVAL;
/* Verify the wdog and setup parameters */
- if (wdog == NULL || wdentry == NULL)
+ if (wdog != NULL && wdentry != NULL)
Review Comment:
Yes. Our goal is not to fully comply with the Advisory rules. Some rules,
such as Rule 11.4, Rule 11.5, and Rule 20.10, cannot be met with minor
modifications for NuttX. However, we should strive to satisfy those MISRA-C
rules that require only minor adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
