Laczen commented on PR #17591:
URL: https://github.com/apache/nuttx/pull/17591#issuecomment-3681849759

   > Hi @Laczen if I understand correctly, we are linking the nxtmpdir/hal to 
Nuttx's build system, right?
   > 
   > This causes a problem where at least for me, I have multiple `nuttxspaces` 
and this breaks it, since the directory is populated with many build objects 
and also, some SoCs might use a different hash for the HAL.
   > 
   > ```
   > fdcavalcanti@espmint:~/nuttxspace4/nxtmpdir/esp-hal-3rdparty 
((4eed03a15b...))
   > $ git clean -xfdn
   > Would remove 
components/bootloader_support/bootloader_flash/src/bootloader_flash.o
   > Would remove 
components/bootloader_support/bootloader_flash/src/bootloader_flash_config_esp32.o
   > Would remove 
components/bootloader_support/bootloader_flash/src/flash_qio_mode.o
   > Would remove components/bootloader_support/src/bootloader_clock_init.o
   > Would remove components/bootloader_support/src/bootloader_clock_loader.o
   > Would remove components/bootloader_support/src/bootloader_common.o
   > Would remove components/bootloader_support/src/bootloader_common_loader.o
   > Would remove components/bootloader_support/src/bootloader_console.o
   > Would remove components/bootloader_support/src/bootloader_console_loader.o
   > Would remove components/bootloader_support/src/bootloader_efuse.o
   > ...
   > ```
   > 
   > What was the issue in using NXTMPDIR environment variable? It was just as 
fast and is working fine. It keeps the folder intact and can be reused by any 
number of `nuttxspaces`.
   > 
   > ```
   > $ NXTMPDIR=../nxtmpdir/ make -j10
   > ```
   > 
   > In a simplified way, this approach uses the `nxtmpdir` as the 'repository' 
and copies the esp-hal-3rdparty to the NuttX build system instead of 
downloading everything. This has the advantage of bringing the git history and 
is quite fast.
   
   The problem with using the NXTMPDIR environment variable is that each time 
after distclean it would update the mbedtls and component/esp_phy/... 
submodules. This is slow and always requires a internet connection. Also the 
copying of esp-hal-3rdparty can be slow.
   
   Maybe a change to the `CHECK_COMMIT_SHA` using `git reset --hard` can be 
used to avoid your multiple nuttxspaces setup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to