Re: [PR] include/nuttx: Introduce seqlock, a sequential count based read-write lock. [nuttx]

Sun, 21 Dec 2025 19:24:42 -0800 


Fix-Point commented on PR #17569:
URL: https://github.com/apache/nuttx/pull/17569#issuecomment-3680243041

   > This commit has too many patches. Could it be consolidated into several 
focused commits based on feature sets, such as arch, seqlock, and doc? This is 
just a suggestion; you can keep it if you wish.
   > 
   > <img alt="image" width="881" height="478" 
src="https://private-user-images.githubusercontent.com/758493/529058953-421a440b-2c02-4e80-afa5-33828f90c17b.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjYzNzI1ODUsIm5iZiI6MTc2NjM3MjI4NSwicGF0aCI6Ii83NTg0OTMvNTI5MDU4OTUzLTQyMWE0NDBiLTJjMDItNGU4MC1hZmE1LTMzODI4ZjkwYzE3Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjIyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIyMlQwMjU4MDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Y2E4ZjAwY2I5Y2VmNWI1NGRlYWE2MmEwYzVmMjRiMjBmMGZmZTcxY2Y4YmIxNDE5NmNlNDlmYjZkZTlhNWUzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.QZbt2N34boILPzjx6eJDVsyeNn76_6k1B7DTIU7C_Q4";>
 <img alt="image" width="893" height="192" 
src="https://private-user-images.githubusercontent.com/758493/529058986-f17bb454-5673-4274-95d8-bbb6cbfa9c34.png?jwt=eyJ0eXAiOiJ
 
KV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjYzNzI1ODUsIm5iZiI6MTc2NjM3MjI4NSwicGF0aCI6Ii83NTg0OTMvNTI5MDU4OTg2LWYxN2JiNDU0LTU2NzMtNDI3NC05NWQ4LWJiYjZjYmZhOWMzNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjIyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIyMlQwMjU4MDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jY2NiN2RiYTU4NTg4Y2VmZTkyYzcxMTNiMzE2ZTgxMDFmMGZmMzVlMWRiY2UzMjc0YzEzYjRhZmExNWFlYzc3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.PU285h0MgBcqe1AcaD7CNHzzdXdyWTETPihZ1iuQdcY">
   
   I support your point. If all these commits were completed by me alone, I 
would definitely consolidate them into a few commits (as I've done in past PRs).
   
   However, these PR also include commits of some of my colleagues, such as 
@hujun260, @wangzhi16 and @zhangyuduck   consolidating their commits would be 
disrespectful to their work.
   
   So I'm sorry that I can not make this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to