jasonbu commented on PR #3219: URL: https://github.com/apache/nuttx-apps/pull/3219#issuecomment-3674178558
> > The change which fix the compiler issue, don't need runtime log to indicate wether the modification is correct or not. > > I disagree because this PR introduces compile time changes that conditionally removes logic. It would be good to see testing of the modified examples. hi, @linguini1 , rebased to the master code, and double check it still works as expected, and updated in the pr content. please check. about the cmocka case test_nuttx_syscall_getsockopt01/test_nuttx_syscall_setsockopt01. the testcode using PF_INET/AF_INET, those is not supported if IPv4 not enabled, will cause net_sockif goto defaultNULL branch. so to minimal change the case, just close when IPv4 not enabled should prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
