patacongo commented on pull request #1562:
URL: https://github.com/apache/incubator-nuttx/pull/1562#issuecomment-677846000


   > 
   > 
   > @xiaoxiang781216 @patacongo
   > I have an idea:
   > I'll write generic versions for createstack, usestack, checkstack and 
perhaps other stack functions with parameters for full/empty, 
descending/ascending and alignment which can then be called from the arch 
functions with the correct parameter set.
   > What do you think about?
   
   Please DO NO DO THAT.  That violates the modular architecture of the 
architectures.  A change like that must never come into to the 
OS!!!!!!!!!!!!!!!!
   
   Please see the top-level INVIOLABLES.txt and also 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=139629399
   
   Lets avoid thinking in this way.  Please think of all architectures as fully 
self contained and NOT couple through any common logic like this.  In this 
case, duplication of code is a very good thing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to