Cynerd commented on code in PR #17441: URL: https://github.com/apache/nuttx/pull/17441#discussion_r2605606872
########## drivers/can/can.c: ########## @@ -518,7 +518,7 @@ static ssize_t can_read(FAR struct file *filep, FAR char *buffer, /* ret can be more than buflen due to roundup, so return at most buflen */ - return ret ? MIN(ret, buflen) : -EMSGSIZE; + return ret ? MIN(ret, (int)buflen) : -EMSGSIZE; Review Comment: @raiden00pl I still think that it should be typed to `ssize_t` and not `int` as that is the returned type. In `can_read`, the variable `ret` should have been `ssize_t` as well, for the same reason. I think that we should make this change as part of this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
