This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit ad422684d409c41f433e0cfd2da0f58341872f7a
Author: zhangkai25 <[email protected]>
AuthorDate: Mon Jun 9 14:06:39 2025 +0800

    drivers/net: Ethernet protocol stack key abnormal point pile for DFX
    
    add log output for error flow
    
    Signed-off-by: zhangkai25 <[email protected]>
---
 drivers/net/netdev_upperhalf.c | 5 +++++
 drivers/net/vlan.c             | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/drivers/net/netdev_upperhalf.c b/drivers/net/netdev_upperhalf.c
index 185e160d98e..fbbdc8d8320 100644
--- a/drivers/net/netdev_upperhalf.c
+++ b/drivers/net/netdev_upperhalf.c
@@ -321,6 +321,7 @@ static int netdev_upper_txpoll(FAR struct net_driver_s *dev)
        */
 
       NETDEV_TXERRORS(dev);
+      nerr("ERROR: Transmit failed: %d\n", ret);
       netpkt_put(dev, pkt, NETPKT_TX);
       return ret;
     }
@@ -715,6 +716,7 @@ static void netdev_upper_rxpoll_work(FAR struct 
netdev_upperhalf_s *upper)
 
           NETDEV_RXDROPPED(dev);
           netpkt_free(lower, pkt, NETPKT_RX);
+          nerr("ERROR: Dropped frame due to lower dev not up\n");
           continue;
         }
 
@@ -1342,6 +1344,7 @@ int netdev_lower_register(FAR struct netdev_lowerhalf_s 
*dev,
   if (dev == NULL || dev->ops == NULL ||
       dev->ops->transmit == NULL || dev->ops->receive == NULL)
     {
+      nerr("ERROR: Invalid lower half device\n");
       return -EINVAL;
     }
 
@@ -1375,6 +1378,7 @@ int netdev_lower_register(FAR struct netdev_lowerhalf_s 
*dev,
   ret = netdev_register(&dev->netdev, lltype);
   if (ret < 0)
     {
+      nerr("ERROR: Netdev_register failed: %d\n", ret);
       kmm_free(upper);
       dev->netdev.d_private = NULL;
     }
@@ -1417,6 +1421,7 @@ int netdev_lower_unregister(FAR struct netdev_lowerhalf_s 
*dev)
 
   if (dev == NULL || dev->netdev.d_private == NULL)
     {
+      nerr("ERROR: Invalid lower half device\n");
       return -EINVAL;
     }
 
diff --git a/drivers/net/vlan.c b/drivers/net/vlan.c
index 4447b7b2726..78259d52192 100644
--- a/drivers/net/vlan.c
+++ b/drivers/net/vlan.c
@@ -282,6 +282,7 @@ int vlan_register(FAR struct netdev_lowerhalf_s *real, 
uint16_t vid,
 
   if (real == NULL || real->netdev.d_lltype != NET_LL_ETHERNET)
     {
+      nerr("ERROR: Invalid real device\n");
       return -EINVAL;
     }
 
@@ -296,6 +297,7 @@ int vlan_register(FAR struct netdev_lowerhalf_s *real, 
uint16_t vid,
   vlan = kmm_zalloc(sizeof(struct vlan_device_s));
   if (vlan == NULL)
     {
+      nerr("ERROR: Failed to allocate memory for VLAN device\n");
       return -ENOMEM;
     }
 
@@ -323,6 +325,7 @@ int vlan_register(FAR struct netdev_lowerhalf_s *real, 
uint16_t vid,
   ret = netdev_lower_vlan_add(real, vid, &vlan->dev);
   if (ret < 0)
     {
+      nerr("ERROR: Failed to add VLAN device: %d\n", ret);
       goto errout;
     }
 
@@ -360,6 +363,7 @@ void vlan_unregister(FAR struct netdev_lowerhalf_s *dev)
 
   if (vlan == NULL)
     {
+      nerr("ERROR: Vlan is NULL\n");
       return;
     }
 

Reply via email to