acassis commented on PR #17352: URL: https://github.com/apache/nuttx/pull/17352#issuecomment-3574974931
> > Thank you guys! I have sent the update on the mailing list with this PR and [apache/nuttx-apps#3217](https://github.com/apache/nuttx-apps/pull/3217) (applications update signal disable). > > What is the Signal Disable impact on the Drivers? > > With the partial signal disable solution, driver which notify the event to userspace through signal still work if it uses sigwaitinfo(not signal handler) to receive the event, for example, button driver notification example work as before: https://github.com/apache/nuttx/blob/master/include/nuttx/input/buttons.h#L77-L111 https://github.com/apache/nuttx-apps/blob/master/examples/buttons/buttons_main.c#L201-L256 but this example can't work with the full signal disable. On the other hand, timer driver example can't work with both approach: https://github.com/apache/nuttx-apps/blob/master/examples/timer/timer_main.c#L84-L97 since it receive the event through signal handler. I think that is a good feature if we could still getting working the buttons, zerocross and other drivers that depends on signal. @xiaoxiang781216 @wangchdo @anchao I think most of people that will decide it doesn't have the complete understanding how signals working on NuttX. I suggest creating a Documentation explains how do signals work on NuttX. It could be an overview, but should explain details as @anchao commented about signals on NuttX using the ISR context, etc. Also if should explain how to partial disable works. @xiaoxiang781216 @wangchdo is it possible to have more two disable levels: partial (where buttons, etc, works) and full (not signal at all, buttons will not work) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
