anchao commented on PR #17352: URL: https://github.com/apache/nuttx/pull/17352#issuecomment-3556746240
> you can't disable signals under POSIX. As much as I like this change and minimizing the footprint of NuttX, this change is against INVIOLABLES.md and it certainly can't be merged without more discussion in the community. @raiden00pl I like this PR because our internal branch has already decoupled the file system and signal functionalities, which is very useful for reducing memory consumption and improving performance. DISABLE_SIGNALS in previous discussions: https://github.com/apache/nuttx/issues/11390 As described in this PR, Nuttx couldn't decouple its sleep system from signals in the previous version, which led @gregory-nutt to remove support for DISABLE_SIGNAL directly. After commits #17200 and #17204, signals are no longer a mandatory option for the system. In some lightweight POSIX scenarios, they can avoid signal checks in the kernel scheduling flow, playing a crucial role in performance improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
