ppisa commented on PR #17283: URL: https://github.com/apache/nuttx/pull/17283#issuecomment-3492423145
@Cynerd, thanks for the CAN chardev interface extension. I think that it simplifies lot of code where elimination of expensive syscalls for really high throughput is not required. In the NutX case multiple messages read in one go could have effect only in MMU or protected case. As for the name ` CANIOC_SET_IWATERMARK`, I am not sure if it is self-descriptive. It probably originates in termios style of IOCTLs building. But ` CANIOC_SET_RDMSGLIMIT` or ` CANIOC_SET_RDWATERMARK` or... would be more descriptive to me. I am not sure, but my initial read of the observation did not bring to the intended meaning and I have had to read the code and documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
