linguini1 commented on PR #17276: URL: https://github.com/apache/nuttx/pull/17276#issuecomment-3487370618
Hi @Fix-Point, a few things: 1) Great work! I know there are a lot of people who are excited for this change, including myself. I plan to re-watch your workshop presentation soon to get a better understanding 2) As I think was mentioned, please include some extensive documentation about this new feature. How does it work, when should it be used, does it make any guarantees (big one is to not timeout before the actual duration has passed), etc. You can even link to your talk from the docs. It would be really helpful not only to new users but also for developers, as I see this is replacing a lot of other timer implementations (?) 3) This PR is 47 commits long right now (not sure if that's intentional). I think we should split some of this up into multiple PRs if possible (i.e. one to add the feature, another for replacing existing timer usage with the new feature, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
