TangMeng12 commented on code in PR #17236:
URL: https://github.com/apache/nuttx/pull/17236#discussion_r2472126474


##########
Kconfig:
##########
@@ -264,6 +264,14 @@ config APPS_DIR
                example, to include makefile fragments (e.g., .config or 
Make.defs)
                or to set up include file paths.
 
+config ALLOW_DOWNLOADS

Review Comment:
   `ARCH_CHIP_ESPRESSIF` has been removed in the [risc-v/espressif: Rename 
espressif/esp32c3 as 
esp32c3](https://github.com/apache/nuttx/commit/d1db1810add5c280489a4782a067249a806a6596)
 submission, it seems to be an obsolete config. 
   
   I changed the pr: remove the `default y`  for `ALLOW_DOWNLOADS`, and use 
espressif's boards to select `ALLOW_DOWNLOADS` to enable it. This method 
currently seems to be the most suitable way to modify it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to