linguini1 commented on PR #17222: URL: https://github.com/apache/nuttx/pull/17222#issuecomment-3426922570
> I personally don't support the addition of the wakeup function since now all the `up_delay` have been replaced with this new implementation, and `up_delay` would never return before the timeout. We're changing the behavior all over the code. This is a sleep function, not for waiting on a condition, just sleeping. I don't see a use case this is needed either, just use a semaphore. I see now that even the previous implementation of `nxsched_sleep` could wake up the task early since it was implemented as waiting for a signal. So I do agree in that sense that this PR wouldn't necessarily change that behaviour. Although, I still think it shouldn't be possible to wake up a sleeping task before its timeout since that behaviour is not intuitive and doesn't seem correct for a delay/sleep function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
