jlaitine commented on code in PR #17010:
URL: https://github.com/apache/nuttx/pull/17010#discussion_r2344659956
##########
boards/boardctl.c:
##########
@@ -133,16 +133,25 @@ static inline int
case BOARDIOC_USBDEV_CONNECT: /* Connect the CDC/ACM device */
#ifndef CONFIG_CDCACM_COMPOSITE
{
- DEBUGASSERT(ctrl->handle != NULL);
ret = cdcacm_initialize(ctrl->instance, ctrl->handle);
}
#endif
break;
case BOARDIOC_USBDEV_DISCONNECT: /* Disconnect the CDC/ACM device
*/
{
- DEBUGASSERT(ctrl->handle != NULL && *ctrl->handle != NULL);
- cdcacm_uninitialize(*ctrl->handle);
+#ifdef CONFIG_SYSTEM_CDCACM
+ if (ctrl->instance == CONFIG_SYSTEM_CDCACM_DEVMINOR)
+ {
+ ret = cdcacm_uninitialize_system_cdcacm();
+ }
+ else
+#endif
+ {
+ DEBUGASSERT(ctrl->handle != NULL &&
+ *ctrl->handle != NULL);
+ cdcacm_uninitialize(*ctrl->handle);
Review Comment:
Of course; it would be possible to dig out the handle from the filesystem,
by using the "instance" number ("x"), generating the filename "/dev/ttyACMx",
finding the inode and finally using inode->priv. I just feel that it is
unnecessarily complex for this purpose. Again, if someone uses
"CONFIG_SYSTEM_CDCACM", there is only just one of those, and it is simple to
store the pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
