simbit18 commented on code in PR #16936: URL: https://github.com/apache/nuttx/pull/16936#discussion_r2315456610
########## drivers/net/oa_tc6/Make.defs: ########## @@ -0,0 +1,39 @@ +############################################################################ +# drivers/net/oa/Make.defs +# Review Comment: drivers/net/oa/Make.defs -> drivers/net/oa_tc6/Make.defs] ########## drivers/net/oa_tc6/Kconfig: ########## @@ -0,0 +1,38 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +menuconfig NET_OA_TC6 + bool "OPEN Alliance 10BASE-T1x MAC-PHYs" + default n + depends on NETDEVICES + ---help--- + Enable support for OPEN Alliance protocol SPI MAC-PHYs. + +if NET_OA_TC6 + +config NET_OA_TC6_NCV7410 + bool "Onsemi NCV7410 (NCN26010) 10BASE-T1S SPI MAC-PHY Support" + default n + +config NET_OA_TC6_NCV7410_LEDS + bool "Setup NCV7410 DIO outputs as status LEDs" + default n + depends on NET_OA_TC6_NCV7410 Review Comment: line 22 remove spaces and add a TAB ########## drivers/net/oa_tc6/Kconfig: ########## @@ -0,0 +1,38 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +menuconfig NET_OA_TC6 + bool "OPEN Alliance 10BASE-T1x MAC-PHYs" + default n + depends on NETDEVICES + ---help--- + Enable support for OPEN Alliance protocol SPI MAC-PHYs. + +if NET_OA_TC6 + +config NET_OA_TC6_NCV7410 + bool "Onsemi NCV7410 (NCN26010) 10BASE-T1S SPI MAC-PHY Support" + default n + +config NET_OA_TC6_NCV7410_LEDS + bool "Setup NCV7410 DIO outputs as status LEDs" + default n + depends on NET_OA_TC6_NCV7410 + ---help--- + Setup DIO0 to blink on TX/RX and DIO1 to reflect the LCTL bit in the PHY CONTROL register (Up/Down). + +config NET_OA_TC6_LAN865X + bool "Microchip LAN865x 10BASE-T1S SPI MAC-PHY Support" + default n + +config NET_OA_TC6_LAN865X_MAC + int "LAN865x lower 3 bytes of MAC address" + default 0 + range 0 16777215 + depends on NET_OA_TC6_LAN865X Review Comment: lines 33-34 remove spaces and add a TAB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
