acassis commented on code in PR #16939:
URL: https://github.com/apache/nuttx/pull/16939#discussion_r2310520546
##########
sched/signal/sig_dispatch.c:
##########
@@ -755,12 +755,12 @@ int nxsig_dispatch(pid_t pid, FAR siginfo_t *info, bool
thread)
{
if (thread)
{
- /* Before the notification, we should validate the tid and
- * and make sure that the notified thread is in same process
- * with the current thread.
+ /* Before the notification, we should validate the tid. If the
+ * signal is to be delivered to a thread which has exited, it is
+ * just dropped.
*/
- if (stcb != NULL && group == this_task()->group)
+ if (stcb != NULL)
Review Comment:
@jlaitine isn't the original test an extra protection case some thread
modify its group? (just asking, I didn't look the entire code)
BTW I think your comment is the right one, even for original code that was
there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
