patacongo commented on a change in pull request #1562:
URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468619696



##########
File path: arch/arm/src/common/arm_createstack.c
##########
@@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t 
stack_size, uint8_t ttype)
       /* Save the adjusted stack values in the struct tcb_s */
 
       tcb->adj_stack_ptr  = (uint32_t *)top_of_stack;
-      tcb->adj_stack_size = size_of_stack;
+      tcb->adj_stack_size = size_of_stack -

Review comment:
       > But I think arm_vfork.c is save. (I don't see it beeing set there).
   
   I was surprised to see it there too.  Turns out, my grep was just bad and 
caught this link in arm_vfork.c:
   
      stacksize = parent->adj_stack_size + CONFIG_STACK_ALIGNMENT - 1;
   
   It has bother adj_stack_size and " = ".  Sorry I was not careful.  My 
mistake.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to