Ouss4 commented on a change in pull request #358:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/358#discussion_r468504726
##########
File path: graphics/lvgl/Makefile
##########
@@ -74,13 +74,9 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
@echo "Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
$(Q) $(UNPACK) $(LVGL_TARBALL)
$(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
- $(Q) touch $(LVGL_UNPACKNAME)
Review comment:
So it's your `mv` that's changing the timestamps?
It looks like it's an `mv` version issue. There are some explanations
[here](https://unix.stackexchange.com/questions/503233/when-does-mv-change-the-timestamp-of-a-file-and-while-does-it-not).
I don't think we should rely on the details of `mv` implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
