michallenc commented on PR #16836: URL: https://github.com/apache/nuttx/pull/16836#issuecomment-3197009191
> @nmaggioni @fdcavalcanti @jerpelea seems like there is not a single driver that implements all the APIs: > > ``` > $ git grep ANIOC_SAMPLES_ON_READ > adc.c: case ANIOC_SAMPLES_ON_READ: > $ git grep ANIOC_GET_NCHANNELS > ads1115.c: case ANIOC_GET_NCHANNELS: > mcp3008.c: case ANIOC_GET_NCHANNELS: > acassis@dev:~/nuttxspace/nuttx/drivers/analog$ git grep ANIOC_TRIGGER > Kconfig: Note that the ADC conversion is started via the ANIOC_TRIGGER iotcl. > ads1115.c: case ANIOC_TRIGGER: > ads7828.c: * Controls which channels are read on ANIOC_TRIGGER. By default all > ads7828.c: case ANIOC_TRIGGER: > ads7828.c: /* Add a channel to list of channels read on ANIOC_TRIGGER */ > ads7828.c: /* Remove a channel from list of channels read on ANIOC_TRIGGER */ > lmp92001.c: case ANIOC_TRIGGER: > ltc1867l.c: if (cmd == ANIOC_TRIGGER) > max1161x.c: * Controls which channels are read on ANIOC_TRIGGER. By default all > max1161x.c: case ANIOC_TRIGGER: > max1161x.c: /* Add a channel to list of channels read on ANIOC_TRIGGER */ > max1161x.c: /* Remove a channel from list of channels read on ANIOC_TRIGGER */ > mcp3008.c: case ANIOC_TRIGGER: > ``` > > The current APIs are very limited (better saying: cumbersome), it should have a required ANIOC_CAP to return which features each driver supports. Notice that this driver in this PR doesn't have read() function, like many others in the mainline. `ANIOC_SAMPLES_ON_READ` is implemented in the driver's upper layer if I remember correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
