xiaoxiang781216 commented on code in PR #16842:
URL: https://github.com/apache/nuttx/pull/16842#discussion_r2271894272
##########
arch/arm/src/rp2040/rp2040_adc.h:
##########
@@ -85,7 +85,7 @@ extern "C"
* OK on success or an ERROR on failure
****************************************************************************/
-int rp2040_adc_setup(const char *path,
+int rp2040_adc_initialize(const char *path,
bool read_adc0,
Review Comment:
```suggestion
bool read_adc0,
```
##########
arch/arm/src/rp2040/rp2040_adc.c:
##########
@@ -604,7 +612,7 @@ static int my_ioctl(struct adc_dev_s *dev,
* success or NULL (with errno set) on failure
****************************************************************************/
-int rp2040_adc_setup(const char *path,
+int rp2040_adc_initialize(const char *path,
bool read_adc0,
Review Comment:
```suggestion
bool read_adc0,
```
##########
arch/arm/src/rp2040/rp2040_adc.c:
##########
@@ -544,37 +552,37 @@ static void my_shutdown(struct adc_dev_s *dev)
*
****************************************************************************/
-static void my_rxint(struct adc_dev_s *dev, bool enable)
+static void adc_rxint(struct adc_dev_s *dev, bool enable)
{
if (enable)
{
- ainfo("entered: enable: 0x%08lX\n", dev);
+ ainfo("Enabling: 0x%08lX\n", dev);
- add_device(dev);
+ adc_add_device(dev);
}
else
{
- ainfo("entered: disable: 0x%08lX\n", dev);
+ ainfo("Disabling: 0x%08lX\n", dev);
- remove_device(dev);
+ adc_remove_device(dev);
}
}
/****************************************************************************
- * Name: my_ioctl
+ * Name: adc_ioctl
*
* Description:
* All ioctl calls will be routed through this method
*
****************************************************************************/
-static int my_ioctl(struct adc_dev_s *dev,
+static int adc_ioctl(struct adc_dev_s *dev,
int cmd,
Review Comment:
```suggestion
int cmd,
```
##########
arch/arm/src/rp2040/rp2040_adc.c:
##########
@@ -435,20 +435,20 @@ void remove_device(struct adc_dev_s *dev)
*
****************************************************************************/
-static int my_bind(struct adc_dev_s *dev,
+static int adc_bind(struct adc_dev_s *dev,
const struct adc_callback_s *callback)
Review Comment:
```suggestion
const struct adc_callback_s *callback)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
