cederom commented on PR #16823:
URL: https://github.com/apache/nuttx/pull/16823#issuecomment-3176656710

   Update from the mailing list: @jerpelea proposes to use `!` (exclamation 
mark) as the first character of git commit topic and PR title for breaking 
changes. 
   
   I like the idea best as it is most versatile no matter what comes after, 
costs only single char, and its easy to parse.
   
   But it does not seem to align with Conventional Commits spec.. and so we may 
propose that idea over there? :-)
   
   I also agree that "BREAKING CHANGE" should be put somewhere in the git 
commit message and PR description, just in case someone does not know what the 
"!" means, or parses logs by "BREAKING" string. If we want to put this in the 
footer as Conventional Commits declares, then a short sentence on how to fix 
should follow (i.e. BREAKING COMIMT: lvgl api changed from 8 to 9, update your 
code.).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to