acassis commented on code in PR #16819: URL: https://github.com/apache/nuttx/pull/16819#discussion_r2260314877
########## drivers/sensors/lsm6dso32_uorb.c: ########## @@ -1905,6 +1905,7 @@ int lsm6dso32_register(FAR struct i2c_master_s *i2c, uint8_t addr, priv->gyro.lower.type = SENSOR_TYPE_GYROSCOPE; priv->gyro.lower.ops = &g_sensor_ops; + priv->gyro.lower.nbuffer = 10; Review Comment: Please "define a ODR_BUFFER_SIZE 10" in the Pre-processor Definition area instead of hard-code the value here. This way it could be easier to people discover and change this value ########## drivers/sensors/lis2mdl_uorb.c: ########## @@ -1307,6 +1307,7 @@ int lis2mdl_register(FAR struct i2c_master_s *i2c, int devno, uint8_t addr, priv->lower.ops = &g_sensor_ops; priv->lower.type = SENSOR_TYPE_MAGNETIC_FIELD; + priv->lower.nbuffer = 10; Review Comment: Ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
