raiden00pl commented on code in PR #16818: URL: https://github.com/apache/nuttx/pull/16818#discussion_r2259508861
########## boards/arm/stm32h5/nucleo-h563zi/src/stm32_can.c: ########## @@ -0,0 +1,95 @@ +/**************************************************************************** + * boards/arm/stm32h5/nucleo-h563zi/src/stm32_can.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <errno.h> +#include <debug.h> + +#include <nuttx/can/can.h> +#include <arch/board/board.h> + +#include "chip.h" +#include "arm_internal.h" +#include "stm32.h" +#include "stm32_fdcan.h" +#include "nucleo-h563zi.h" + +#ifdef CONFIG_CAN + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Configuration ************************************************************/ + +#if !defined(CONFIG_STM32H5_FDCAN1) && !defined(CONFIG_STM32H5_FDCAN2) +# error "No CAN device is enabled. Please enable at least one CAN device" +#endif + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: stm32_can_setup + * + * Description: + * Initialize CAN and register the CAN device + * + ****************************************************************************/ + +int stm32_can_setup(uint8_t port) +{ + struct can_dev_s *can; + int ret; + + /* Call stm32_fdcaninitialize() to get an instance of the CAN interface */ + + can = stm32_fdcaninitialize(port); + if (can == NULL) + { + canerr("ERROR: Failed to get CAN interface\n"); + return -ENODEV; + } + + if (port == 1) + { + ret = can_register("/dev/can1", can); + } + else if (port == 2) + { + ret = can_register("/dev/can2", can); + } + else + { + ret = -ENODEV; + } Review Comment: please start from `/dev/can0`. The general rule for numbering devices is that we start with zero. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
