acassis commented on code in PR #16809:
URL: https://github.com/apache/nuttx/pull/16809#discussion_r2253969689
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -4584,125 +4584,451 @@ config STM32H7_ADC3_TIMTRIG
---help---
Values 0:CC1 1:CC2 2:CC3 3:CC4 4:TRGO
+config STM32H7_CAP
+ bool
+ default n
+ select CAPTURE
Review Comment:
Please use TAB here to format the line
##########
drivers/timers/capture.c:
##########
@@ -469,30 +469,27 @@ int cap_register(FAR const char *devpath, FAR struct
cap_lowerhalf_s *lower)
}
int cap_register_multiple(FAR const char *devpath,
- FAR struct cap_lowerhalf_s **lower, int n)
+ FAR struct cap_lowerhalf_s **lower,
+ int n)
{
- FAR struct cap_upperhalf_s *upper;
+ char fullpath[16];
+ int ret;
- /* Allocate the upper-half data structure */
+ if (n < 1) return -EINVAL;
Review Comment:
Please change to:
```
if (n < 1)
{
return -EINVAL;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
