xiaoxiang781216 commented on code in PR #16789:
URL: https://github.com/apache/nuttx/pull/16789#discussion_r2241834799
##########
boards/xtensa/esp32/common/src/esp32_board_spiflash.c:
##########
@@ -405,6 +405,17 @@ static int init_storage_partition(void)
return ret;
}
+#elif defined(CONFIG_MTD_NVBLK)
+
+ ret = nvblk_initialize(0, mtd, CONFIG_MTD_NVBLK_DEFAULT_LBS,
Review Comment:
> @xiaoxiang781216 multiple ftl support should be possible. Adding a choice
option for mtd_proxy could work, but is also very limiting: how to support
mtd_proxy with FTL and dhara/nvblk. FTL, dhara and nvblk are libraries that
should be coupled with a specific MTD, what library is used cannot be queried
from the MTD structure. It is simpler to let the user define the type of block
device (ftl, dhara, nvblk, ...).
The support of multiple algo is still exist, but you need wrap mtd with algo
by self in board initialization, auto FTL wrapper need be done by selecting one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
