TimJTi opened a new issue, #3146:
URL: https://github.com/apache/nuttx-apps/issues/3146

   ### Is your feature request related to a problem? Please describe.
   
   The nxboot.h header file is currently located in `apps/boot/nxboot/include` 
directory
   
   Should this not be moved to `apps/include/boot `(or a similarly named 
subdirectory of apps/include to make it easier for  apps - including custom 
"out-of-tree" apps - to include it without having to use convoluted paths in 
the #include statement?
   
   The header has a number of public function definitions that - as I 
understand it - would typically be needed by user apps, like:
   
   ```
   int nxboot_get_state(struct nxboot_state *state);
   int nxboot_confirm(void);
   int nxboot_get_confirm(void);
   int nxboot_open_update_partition(void);
   ```
   
   It does also include  some most likely "non-public" definitions such as:
   
   ```
   int nxboot_ramcopy(void);
   void nxboot_progress(enum progress_type_e type, ...);
   ```
   
   and enums etc. So we probably need a "local" header file as well as a 
"public" one?
   
   @michallenc - thoughts?
   
   ### Describe the solution you'd like
   
   I am happy to work on the PR after input and suggestions from others, if 
this is agreed to be a good change.
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Verification
   
   - [x] I have verified before submitting the report.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to