linguini1 opened a new pull request, #16764: URL: https://github.com/apache/nuttx/pull/16764
## Summary Sometimes this driver will boot when the serial port is of the wrong baud rate, and it cannot set the correct baud rate or verify communication. This commit prevents registration if any settings fail to be set, and also prevents the kernel thread from setting the L86 to enabled (this is done only by the uORB upper half). ## Impact Impacts only this driver. Removes possibility for kernel crash, instead fails gracefully. ## Testing Prior to this change, a misconfiguration of the serial baud rate would result in a kernel crash. Now this is the behaviour: ```console l86xxx_register: Waiting for GNSS to start... send_command: Sending command: $PMTK251,9600 to L86 send_command: Sending command: $PMTK220,1000 to L86 send_command: Waiting for ACK from L86... send_command: Did not get ACK! l86xxx_register: Couldn't set position fix interval, -5 Failed to register L86-M33: -5 NuttShell (NSH) NuttX-12.8.0 nsh> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
