tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2219173998
########## drivers/misc/optee_supplicant.h: ########## @@ -0,0 +1,73 @@ +/**************************************************************************** + * drivers/misc/optee_supplicant.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __DRIVERS_MISC_OPTEE_SUPPLICANT_H +#define __DRIVERS_MISC_OPTEE_SUPPLICANT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <sys/types.h> +#include "optee.h" + +/**************************************************************************** + * Public Functions Prototypes + ****************************************************************************/ + +#undef EXTERN +#if defined(__cplusplus) +#define EXTERN extern "C" +extern "C" +{ +#else +#define EXTERN extern +#endif + +void optee_supplicant_init(void); +void optee_supplicant_uninit(void); +bool optee_supplicant_running(void); + +FAR struct idr_s *optee_supplicant_get_shm_idr(void); +FAR struct idr_s *optee_supplicant_init_shm_idr(void); + +uint32_t optee_supplicant_request(uint32_t func, size_t num_params, + FAR struct tee_ioctl_param *param); + +uint32_t optee_supplicant_cmd_free(int32_t shm_id); +int32_t optee_supplicant_cmd_alloc(FAR struct optee_priv_data *priv, + size_t sz, FAR struct optee_shm **shm); + +void optee_supplicant_cmd(FAR struct optee_priv_data *priv, + FAR struct optee_msg_arg *arg); + +int optee_supplicant_send(uint32_t ret, uint32_t num_params, Review Comment: I changed optee_supplicant_request to have `uint32_t` instead to match `./include/nuttx/tee.h`: ``` /* struct tee_iocl_supp_recv_arg - Receive a request for a supplicant * function * func: [in] supplicant function * num_params [in/out] number of parameters following this struct * * num_params is the number of params that tee-supplicant has room to * receive when input, num_params is the number of actual params * tee-supplicant receives when output. */ struct tee_iocl_supp_recv_arg { uint32_t func; uint32_t num_params; /* num_params tells the actual number of element in params */ struct tee_ioctl_param params[]; }; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
