simbit18 commented on code in PR #16710:
URL: https://github.com/apache/nuttx/pull/16710#discussion_r2216078668
##########
CMakeLists.txt:
##########
@@ -828,8 +833,7 @@ if(CONFIG_BUILD_PROTECTED)
target_link_libraries(
nuttx_user
- PRIVATE -T
- ${user_ldscript}
+ PRIVATE ${LINK_SCRIPT_FLAG}${user_ldscript}
Review Comment:
- add a space -> ${LINK_SCRIPT_FLAG} ${user_ldscript}
##########
CMakeLists.txt:
##########
@@ -755,8 +759,9 @@ else()
# link the final nuttx binary
add_dependencies(nuttx nuttx-rel)
- target_link_options(nuttx PUBLIC $<$<NOT:$<BOOL:${APPLE}>>:-T nuttx.ld>
- $<$<BOOL:${CONFIG_SIM_M32}>:-m32>)
+ target_link_options(
+ nuttx PUBLIC $<$<NOT:$<BOOL:${APPLE}>>:${LINK_SCRIPT_FLAG}nuttx.ld>
Review Comment:
add a space -> ${LINK_SCRIPT_FLAG} nuttx.ld
##########
CMakeLists.txt:
##########
@@ -659,8 +664,7 @@ if(NOT CONFIG_ARCH_SIM)
target_link_libraries(
nuttx
PRIVATE ${NUTTX_EXTRA_FLAGS}
- -T
- ${ldscript}
+ ${LINK_SCRIPT_FLAG}${ldscript}
Review Comment:
add a space -> ${LINK_SCRIPT_FLAG} ${ldscript}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
