jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3060245260
> Please add Documentation/ with the diagram included in the comments @acassis yes sure, thank you for your comments. I will update the MTD documentation with diagrams, as well as the commit topic > Thank you @jingfei195887 looks interesting :-) > > * @michallenc is out expert in this area so I follow all his remarks :-) > * What happens if we use SYNC flag assuming the memory is erased but it is not erased? Is this scenario handled properly with returning error code? Here I share the same view with @michallenc .It depends on the state of the MTD device, and it may return either success or a write failure. Certainly, we could determine whether the device has been completely erased by performing a read-back operation. However, this approach contradicts our goal of achieving greater simplicity and speed. Therefore, we should leave it to the application layer to ensure data integrity rather than making such judgments at the driver level. > * Please update commits topic prefix to `bch: ...` and `fs/mtd: ...`. yes of course. > * Should we mark this change with `[BREAKING]` tag in the commit topic too? It changes filesystem / mount / mtd in a non-backward compatible way and this should be clearly marked if someone bumps the release and gets a broken code it will help find a fix quickly. Maybe it would be possible to create new function calls with additional flags as new functionality while old API remains untouched (could call new functions with default parameters)? What other folks think? :-) Yes, we need the [BREAKING] tag to remind everyone. I'm new to the NuttX repository, but I noticed that @acassis has already added the [BREAKING] tag, and I will follow this approach > * Should we also update the documentation on the new behavior (i.e. https://nuttx.apache.org/docs/latest/components/drivers/special/mtd.html)? yes I will update the MTD documentation, thanks for your advice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
