Re: [PR] net/arp: avoid unnecessary ARP requests [nuttx]

[via GitHub]

nuttxs commented on code in PR #16684:
URL: https://github.com/apache/nuttx/pull/16684#discussion_r2191592394


##########
net/arp/arp_out.c:
##########
@@ -262,7 +262,7 @@ void arp_out(FAR struct net_driver_s *dev)
 
   /* Check if we already have this destination address in the ARP table */
 
-  ret = arp_find(ipaddr, ethaddr.ether_addr_octet, dev);
+  ret = arp_find(ipaddr, ethaddr.ether_addr_octet, dev, false);

Review Comment:
   Due to the large number of ARP requests here, there is a periodic drop in 
throughput.  
   Reference for packet capture is as follows:  
   
![图片](https://github.com/user-attachments/assets/9f715335-3444-4a79-88d5-ee93bc9ea083)
   
   After the fix, ARP requests are reasonable. Reference for packet capture is 
as follows:  
   
![图片](https://github.com/user-attachments/assets/ea1e0e2a-2fbf-40b7-a8d2-1a9240003989)
   
   - `arp_out()`: Prioritize ensuring data transmission performance and avoid 
unnecessary ARP delays.  
   - Keep `arp_send()`: Active ARP management - ensure the accuracy of the ARP 
table, used to proactively establish and maintain IP-MAC mapping relationships.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org