michallenc commented on code in PR #16642: URL: https://github.com/apache/nuttx/pull/16642#discussion_r2190836078
########## drivers/mtd/ftl.c: ########## @@ -789,7 +883,8 @@ static int ftl_unlink(FAR struct inode *inode) * ****************************************************************************/ -int ftl_initialize_by_path(FAR const char *path, FAR struct mtd_dev_s *mtd) +int ftl_initialize_by_path(FAR const char *path, FAR struct mtd_dev_s *mtd, + int oflags) Review Comment: Good points. I mean, it's not generally a bit problem the flags have to be specified during registration (the driver I proposed had the same issue after all), it just means the application can't force the behavior. I would say the current behavior is good enough given the complications passing the oflags from the BCH's open operation to the FTL's open operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
