xiaoxiang781216 commented on code in PR #16642: URL: https://github.com/apache/nuttx/pull/16642#discussion_r2190238864
########## drivers/bch/bchdev_register.c: ########## @@ -50,17 +50,17 @@ ****************************************************************************/ int bchdev_register(FAR const char *blkdev, FAR const char *chardev, - bool readonly) + int oflags) Review Comment: bchdev_register is an internal api which is only called inside FS layer to convert block device to char device automatically, that's why @jingfei195887 change this function prototype directly. If it's a concern, we can add a new bch register api. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
