xiaoxiang781216 commented on code in PR #16675: URL: https://github.com/apache/nuttx/pull/16675#discussion_r2189071559
########## libs/libc/machine/arm/armv6-m/arch_mcount.S: ########## @@ -0,0 +1,48 @@ +/**************************************************************************** + * libs/libc/machine/arm/armv6-m/arch_mcount.S + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + + .globl __gnu_mcount_nc + + .syntax unified + .file "mcount.S" + + .type __gnu_mcount_nc, %function +__gnu_mcount_nc: + /* ARMv6-M (Cortex-M0) compatible implementation */ + push {r0, r1, r2, r3, lr} /* Save registers */ Review Comment: > Although I can do this, is this change necessary? > > The gprof support for the arm64 architecture is also in its own directory (libs/libc/machine/arm64/arch_mcount.c) arm64 is totally different arch compared with arm32, but armv6 and armv7 is the variant of the same arch. > We don't need to make the armv7/v8 architecture compatible with v6 instructions, they will only reduce efficiency but we just need change: `bic r1, lr, #1` to: `mov r1, lr` `bic r1, r1, #1` or better to skip or move the zero to c code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
