yamt commented on code in PR #16666: URL: https://github.com/apache/nuttx/pull/16666#discussion_r2182237446
########## arch/sim/src/sim/posix/sim_errno.c: ########## @@ -0,0 +1,336 @@ +/**************************************************************************** + * arch/sim/src/sim/posix/sim_errno.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Add holder to detect possible errno in host def.h + * Use ERRNO_HOLDER to make ifdef able to expand at pre-processor time + */ + +#define ERRNO_HOLDER_ 0, Review Comment: is this one necessary? ########## arch/sim/src/sim/posix/sim_errno.c: ########## @@ -0,0 +1,336 @@ +/**************************************************************************** + * arch/sim/src/sim/posix/sim_errno.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Add holder to detect possible errno in host def.h + * Use ERRNO_HOLDER to make ifdef able to expand at pre-processor time Review Comment: what do you think about these concerns? https://github.com/yamt/garbage/blob/4478d1d09d556347062ea6c9b1d161a93775b55e/c/cpp1/a.c#L14-L22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
