tinnedkarma opened a new pull request, #16649:
URL: https://github.com/apache/nuttx/pull/16649
## Summary
I am tinkering around net subsystem / netdevs.
Both NET_IGC_TXDESC and NET_IGC_RXDESC macros were present in the generated
config without me touching anything Intel related.
On further inspection, those configs are used in `drivers/net/igc.c` file
```
...
/* Packet buffer size */
#define IGC_PKTBUF_SIZE 2048
#define IGC_RCTL_BSIZE IGC_RCTL_BSIZE_2048
/* TX and RX descriptors */
#define IGC_TX_DESC CONFIG_NET_IGC_TXDESC
#define IGC_RX_DESC CONFIG_NET_IGC_RXDESC
/* After RX packet is done, we provide free netpkt to the RX descriptor ring.
* The upper-half network logic is responsible for freeing the RX packets
* so we need some additional spare netpkt buffers to assure that it's
* always possible to allocate the new RX packet in the receiver logic.
* It's hard to tell how many spare buffers is needed, for now it's set to 8.
*/
#define IGC_TX_QUOTA IGC_TX_DESC
#define IGC_RX_QUOTA (IGC_RX_DESC + CONFIG_NET_IGC_RXSPARE).
...
```
which is only built if NET_IGC is selected.
```
#nuttx/drivers/net/Make.defs
ifeq ($(CONFIG_NET_IGC),y)
CSRCS += igc.c
endif
```
So I've moved both configs under NET_IGC menu.
## Impact
CONFIG_NET_IGC_TXDESC and CONFIG_NET_IGC_TXDESC will now only appear if
CONFIG_NET_IGC is also enabled
## Testing
I've build the qemu-intel64:jumbo config, and it build fine. No runtime
testing though, as I do not have that hardware.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
