acassis commented on code in PR #16464: URL: https://github.com/apache/nuttx/pull/16464#discussion_r2119245040
########## drivers/dma/dma_align_manager.c: ########## @@ -0,0 +1,30 @@ +#include <nuttx/dma/dma_align_manager.h> +#include <sys/types.h> +int dma_align_manager_init(struct dma_align_manager_s *manager,struct dma_align_manager_init_s *initcfg) +{ + manager->device=initcfg->dev; + manager->allocator=initcfg->allocator; + manager->align_buffer=manager->allocator->alloc_align_buffer(manager->device,initcfg->original_buffer_len); + if(manager->align_buffer==NULL) + { + return -ENOMEM; + } + manager->allocated=true; + return OK; +} +uint8_t *dma_align_manager_get_align_buffer(struct dma_align_manager_s *manager) +{ + return manager->align_buffer; +} +int dma_align_manager_finish(struct dma_align_manager_s *manager) +{ + if(manager->allocated) + { + if(manager->align_buffer) Review Comment: Why don't you use a single if? if (manager->allocated && manager->align_buffer) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org