ids1024 commented on PR #16398: URL: https://github.com/apache/nuttx/pull/16398#issuecomment-2896175055
On my Feather RP2350 board, using `#define BOARD_XOSC_STARTUPDELAY 64`, the commit before this seems to work, but this commit results in SWD debugging showing a "double fault" and the nsh prompt not showing up over serial. Where does the 6 in `#define XOSC_STARTUPDELAY_MULT 6` come from? I don't see anything like that in pico-sdk, though I may be missing it. This change seems to essentially multiply the value by 6, and change how rounding is done. (I noted in the commit message for 806c0632236ccacde28735cfbabafa0ba9b43c45 that I did the rounding slightly differently from pico-sdk in a way that matched the datasheet and seemed a little more logical, but it doesn't really matter). https://github.com/apache/nuttx/blob/master/arch/arm/src/rp2040/rp2040_xosc.c should also be updated for any change here (it would be good if the rp2040 and rp23xx shared code somehow instead of duplicating things like this). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
