acassis commented on code in PR #16369:
URL: https://github.com/apache/nuttx/pull/16369#discussion_r2086713775
##########
drivers/note/Kconfig:
##########
@@ -36,6 +36,19 @@ config DRIVERS_NOTECTL
If this option is selected, the instrumentation filter control
device
/dev/notectl is provided.
+config NOTE_GET_PERF_TIME
+ bool "Note get time config"
+ default y
+ ---help---
+ If this option is selected, then note get time from perf time
+
+config NOTE_GET_CLOCK_TIME
+ bool "Note get time config"
Review Comment:
Please don't use the same message ("Note get time config") in boot configs,
it will confuse users. The description in the config should be clear to the
users!
##########
drivers/note/Kconfig:
##########
@@ -36,6 +36,19 @@ config DRIVERS_NOTECTL
If this option is selected, the instrumentation filter control
device
/dev/notectl is provided.
+config NOTE_GET_PERF_TIME
+ bool "Note get time config"
+ default y
+ ---help---
+ If this option is selected, then note get time from perf time
Review Comment:
Please improve the "---help---", what is "perf time"? What difference to
"clock time", etc. These are question that user need to know before enabling
this option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
