nuttxpr commented on PR #16296: URL: https://github.com/apache/nuttx/pull/16296#issuecomment-2844824747
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. Here's why: * **Summary:** While it mentions the "what" (adding Kconfig and chip.h modifications), it lacks sufficient detail on *how* the change works. What specific Kconfig options were added? What exactly was modified in `chip.h`? What functionality do these changes enable? The reference to #16293 is helpful but shouldn't replace a self-contained explanation. * **Impact:** While it states the impact is adding necessary definitions, it's too general. All "Impact" sections require explicit "YES" or "NO" answers, followed by descriptions if "YES." For example: * Impact on user: NO * Impact on build: YES (The build system will now recognize and be able to configure for STM32G0B1xx MCUs) * Impact on hardware: YES (Enables support for STM32G0B1xx hardware) * ...and so on for *all* impact categories. * **Testing:** This is the most significant deficiency. * The testing description indicates the target and config are not yet supported. This means the core changes in this PR haven't been functionally tested. Testing needs to demonstrate that the added Kconfig options work and the `chip.h` modifications don't introduce errors. Since board support isn't ready, consider testing with a simulator or by verifying successful compilation with the new configuration options. * "Testing logs before change" and "Testing logs after change" sections are empty. Even if the board isn't fully supported, *some* form of build output or other verification should be included. For example, show the Kconfig menu output with the new options or demonstrate successful compilation with and without the changes. To summarize, the PR needs to provide more detail in the Summary and Impact sections and, crucially, demonstrate the changes through actual testing, even if limited by the lack of full board support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
