keever50 commented on code in PR #16281: URL: https://github.com/apache/nuttx/pull/16281#discussion_r2065869939
########## arch/arm/src/rp2040/rp2040_gpio.h: ########## @@ -66,10 +66,10 @@ /* GPIO interrupt modes *****************************************************/ -#define RP2040_GPIO_INTR_LEVEL_LOW 0 -#define RP2040_GPIO_INTR_LEVEL_HIGH 1 -#define RP2040_GPIO_INTR_EDGE_LOW 2 -#define RP2040_GPIO_INTR_EDGE_HIGH 3 +#define RP2040_GPIO_INTR_LEVEL_LOW (0x1) Review Comment: Nice! I do have a suggestion. I believe it is common to use 1<<0, 1<<1, 1<<2... etc for bit **positions** instead hexadecimals. It is not going to matter that much here, but it does make accidentally making errors less common and it increases readability :thinking: But this is fine too Example:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
