jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2065555613
########## sched/semaphore/sem_destroy.c: ########## @@ -61,6 +61,9 @@ int nxsem_destroy(FAR sem_t *sem) { int32_t old; + const bool mutex = NXSEM_IS_MUTEX(sem); + FAR atomic_t *const plock = mutex ? NXSEM_MHOLDER(sem) : NXSEM_COUNT(sem); Review Comment: Changed plock (pointer to lock) into val, according to your suggestion. The suggested re-placement of const is of course wrong. The pointer is const in this context, the value is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org