nuttxpr commented on PR #16274: URL: https://github.com/apache/nuttx/pull/16274#issuecomment-2833510081
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR mostly meets the NuttX requirements but could be improved in the Testing section. While it shows *a* build log, it doesn't show "before" and "after" logs demonstrating the change's functionality. It only shows a single build output. Here's a breakdown of what's good and what needs improvement: **Good:** * **Summary:** Clearly outlines the changes, affected components, and related issues/PRs (if any). * **Impact:** Addresses all the points and provides sufficient detail. * **Build Host/Target Information:** Adequately specifies the build environment and target platform. **Needs Improvement:** * **Testing Logs:** The provided log snippet appears to be just a build output, not a functional test demonstrating the board support *before* and *after* the changes. The requirements explicitly ask for "Testing logs before change" and "Testing logs after change." This is crucial for demonstrating that the new board support actually works and doesn't introduce regressions. **Recommendations for the Testing Section:** 1. **Before Change:** If there was no prior support for this board, explain that. You could state: "Testing logs before change: N/A - No prior support for Seeed Studio XIAO ESP32C3." 2. **After Change:** Provide logs demonstrating the functionality of the five configurations (nsh, usbnsh, gpio, wifi, ble). For example: ``` # nsh config: nsh> help ... (output of the help command showing NSH functionality) ... # usbnsh config: (Connect via USB and interact with NSH - show output proving USB NSH works) # gpio config: nsh> gpioinfo # or any command demonstrating GPIO functionality ... (output showing GPIO information/control) ... # wifi config: nsh> ifconfig wlan0 # Or commands showing wifi connection/scan ... (output showing wifi configuration) ... # ble config: nsh> ble # or any command related to bluetooth operation ... (output showing bluetooth information) ... ``` By providing these specific test logs, you demonstrate that the new board support is functional and that the different configurations work as expected. This makes the PR much stronger and easier for reviewers to assess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
