nuttxpr commented on PR #16261:
URL: https://github.com/apache/nuttx/pull/16261#issuecomment-2829666058

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   No, this PR does not fully meet the NuttX requirements.  While it provides a 
decent amount of information, it lacks critical details in several areas:
   
   * **Summary:**  While the summary explains the problem, it doesn't clearly 
articulate *what* code was changed.  Saying "modify several registers according 
reference manual" is vague.  Specific files and functions modified should be 
mentioned.  Also, there's no mention of a related NuttX issue.
   * **Testing:** This is the biggest weakness.  "Test with our internal 
project" is insufficient.  NuttX requires concrete, reproducible test cases.  
Vague descriptions of internal projects and log messages aren't helpful for 
reviewers.  The "Testing logs before/after change" sections are empty.  
Specific commands used for testing, along with the full output, are needed.  
Crucially, details about the build host and target are missing (OS, compiler 
versions, etc.).  Simply stating "esp32s3-devkit" is not enough.  A 
configuration name is required (e.g., `esp32s3-devkit:default`).
   
   
   To meet the requirements, the PR needs the following improvements:
   
   * **Summary:** Specify the changed files and functions.  If a NuttX issue 
exists, reference it.  Be more specific about the register modifications.
   * **Testing:**
       * Replace vague descriptions with concrete, reproducible test cases. 
Provide commands used for testing.
       * Fill in the "Testing logs before/after change" sections with the 
*actual* logs.
       * Provide detailed information about the build host (OS, CPU, compiler 
version) and target (arch, board, configuration).  For example:
           * Build Host: Linux (Ubuntu 20.04), x86_64, GCC 11.2.0
           * Target: sim:nsh
   
   
   By addressing these points, the PR will adhere more closely to the NuttX 
contribution guidelines and be easier for reviewers to evaluate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to